-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'utc' field from TimeSlicedOutput conf to prevent ConfigError in plugin helpers #1319
Conversation
Helpers/Compat utils can't judge user specifies both localtime/utc or converted result. This changes conf dumpped result but it seems acceptable.
fd2d8f9
to
70aeaaa
Compare
This is incomplete. Incompatibility still exists by |
@tagomoris Could you handle this problem? Currently, v0.14 has incompatibility issue with v0.12 TimeSlicedOutput. Here is one failed case:
|
@tagomoris I added test for this case. Now, test failed.
|
I pushed two commits to fix this problem. |
I tested the patch with s3 plugin test and it fixes broken tests. |
And LGTM |
Helpers/Compat utils can't judge user specifies both localtime/utc or converted result.
This changes conf dumpped result but it seems acceptable.
Without this change, v0.12 TimeSlicedOutput plugins with
utc
parameter don't work.