Fix to wakeup threads to quit loop in threads #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's done before returning from stop/after_shutdown, but after setting flag to break while-loop. This change suppresses log messages like 'thread doesn't exit correctly (killed or other reason)' in shutdown sequence.
|
@repeatedly could you review this change? |
repeatedly
reviewed
Oct 7, 2016
| @@ -416,6 +420,12 @@ def before_shutdown | |||
| force_flush | |||
| end | |||
| @buffer.before_shutdown | |||
| # Need to ensure to stop enqueueing ... after #shutdown, we cannot write any data | |||
| @output_enqueue_thread_running = false | |||
| if @output_enqueue_thread && @output_enqueue_thread.alive? | |||
There was a problem hiding this comment.
No need to do so. Living threads are running or sleeping.
repeatedly
reviewed
Oct 7, 2016
| @_threads_mutex.synchronize do | ||
| @_threads.each_pair do |obj_id, thread| | ||
| @_threads.values.each do |thread| |
There was a problem hiding this comment.
each_value is better for avoding temporary object allocation.
repeatedly
reviewed
Oct 7, 2016
| super | ||
| wakeup_threads = [] | ||
| @_threads_mutex.synchronize do | ||
| @_threads.values.each do |thread| |
|
Others are okay for me. |
|
Okay. I pushed to use |
tagomoris
deleted the
wakeup-threads-in-shutdown-sequence-to-quit-sleep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's done before returning from stop/after_shutdown, but after setting flag to break while-loop.
This change suppresses log messages like 'thread doesn't exit correctly (killed or other reason)' in shutdown sequence.