Run TailWatcher#on_notify before attaching triggers #1261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1229
This commit runs
TailWatcher#on_notify
before attachingstat_trigger
andtimer_trigger
and preventsTailWatcher#on_notify
from running in two different threads(main and event loop thread) at the same time.This change fixes the
can't modify string; temporarily locked
error.I think fluentd v0.12 does not raise the
can't modify string; temporarily locked
error because it runsstat_trigger
andtimer_trigger
afterTailInput#start
finishes and thusTailWatcher#on_notify
is not executed in two threads simultaneously.reproduction steps
same as described in #1229