Instantiate a section with default values even for multi: true
sections
#1210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, "init: true, multi: false" sections were not instantiated (just
[]
for instance variable).But with this behavior, we cannot use default values of these sections, except for the case to set a
blank Config::Element into
conf.elements
.It looks abnormal, and non-useful feature for plugin authors.
So, this change will improve the situation.
Currently, there are some example without this fix:
This code has default type specification twice:
config_set_default
anddefault_type
.With this change:
Furthermore, this code works as you expected (for
<parse>
section without any argument).This looks better than ever.