Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use timecop instead of stub in test_log #1194

Merged

Conversation

cosmo0920
Copy link
Contributor

Related to #1115.

Using stub to freeze time is not good manner.
We should use Timecop to do this. 👮

@tagomoris
Copy link
Member

LGTM.

@tagomoris tagomoris merged commit 221a8c9 into fluent:master Aug 30, 2016
@cosmo0920
Copy link
Contributor Author

Thanks!

@cosmo0920 cosmo0920 deleted the use-timcop-instead-of-stub-in-test-log branch August 30, 2016 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants