Updates dependencies and reduce warnings #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@repeatedly I will include this patch for |
| @@ -159,7 +159,7 @@ def test_configure | |||
| d = create_driver(" | |||
| @type monitor_agent | |||
| bind '127.0.0.1' | |||
| port #{@port} | |||
| port 24200 | |||
There was a problem hiding this comment.
Why use fixed port number?
@port = unused_port is better?
There was a problem hiding this comment.
It's just smallest diff to reduce warnings.
But you're right.
There was a problem hiding this comment.
Updated with unused_port.
tagomoris
force-pushed
the
fix-tests-and-reduce-warnings
branch
from
2d94bdd
to
578f002
Compare
|
I rebased on current master branch, and add a commit to edit upper limits of dependencies. |
|
LGTM |
tagomoris
force-pushed
the
fix-tests-and-reduce-warnings
branch
from
a2d032e
to
39541aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to reduce warnings when we run
rake test.Almost all warnings are about uninitialized variables, and some others are about unused variables.
I did 2 changes at the same time:
Updating dependencies
There seems no reason to specify minor version dependency for some gems. I updated these to depends on (recent) major versions. I think this operation doesn't make any problems, because all of these are development dependencies.
I also remove
jsonruntime dependency, to use bundled json of Ruby runtime.Specifying
jsonversion is bad practice, because it makes problem between ruby version limitations and other module's dependenciesFix implementation of
in_monitor_agentThe previous implementation depends on the behavior of
evalfor string expression, NoMethodError for nil objects and rescuing all errors (and do nothing).It hides any types of unexpected errors... very bad practice.
I rewrote that code with
instance_execwith proc objects, andthrow-catchfor explicit skip for objects in unexpected states. It shows warnings for unexpected errors in logs.