Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port parser filter from fluent-plugin-parser. fix #1189 #1191

Merged
merged 19 commits into from
Nov 10, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 108 additions & 0 deletions lib/fluent/plugin/filter_parser.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
#
# Fluentd
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

require 'fluent/time'
require 'fluent/config/error'
require 'fluent/plugin/filter'
require 'fluent/plugin_helper/parser'
require 'fluent/plugin_helper/compat_parameters'

module Fluent::Plugin
class ParserFilter < Filter
Fluent::Plugin.register_filter('parser', self)

helpers :parser, :compat_parameters

config_param :key_name, :string
config_param :reserve_data, :bool, default: false
config_param :reserve_time, :bool, default: false
config_param :inject_key_prefix, :string, default: nil
config_param :replace_invalid_sequence, :bool, default: false
config_param :hash_value_field, :string, default: nil

attr_reader :parser

def configure(conf)
compat_parameters_convert(conf, :parser)

super

@parser = parser_create
end

FAILED_RESULT = [nil, nil].freeze # reduce allocation cost
REPLACE_CHAR = '?'.freeze

def filter_with_time(tag, time, record)
raw_value = record[@key_name]
if raw_value.nil?
router.emit_error_event(tag, time, record, ArgumentError.new("#{@key_name} does not exist"))
if @reserve_data
return time, handle_parsed(tag, record, time, {})
else
return FAILED_RESULT
end
end
begin
@parser.parse(raw_value) do |t, values|
if values
t = if @reserve_time
time
else
t.nil? ? time : t
end
r = handle_parsed(tag, record, t, values)
return t, r
else
router.emit_error_event(tag, time, record, Fluent::Plugin::Parser::ParserError.new("pattern not match with data '#{raw_value}'"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any cases NOT to return values without ParserError?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but we can't say all existing parsers don't return nil for time and value.
So keeping this behaviour is better for users.

if @reserve_data
t = time
r = handle_parsed(tag, record, time, {})
return t, r
else
return FAILED_RESULT
end
end
end
rescue Fluent::Plugin::Parser::ParserError => e
router.emit_error_event(tag, time, record, e)
return FAILED_RESULT
rescue ArgumentError => e
raise unless @replace_invalid_sequence
raise unless e.message.index("invalid byte sequence in") == 0

raw_value = raw_value.scrub(REPLACE_CHAR)
retry
rescue => e
router.emit_error_event(tag, time, record, Fluent::Plugin::Parser::ParserError.new("parse failed #{e.message}"))
return FAILED_RESULT
end
end

private

def handle_parsed(tag, record, t, values)
if values && @inject_key_prefix
values = Hash[values.map { |k, v| [@inject_key_prefix + k, v] }]
end
r = @hash_value_field ? {@hash_value_field => values} : values
if @reserve_data
r = r ? record.merge(r) : record
end
r
end
end
end
5 changes: 3 additions & 2 deletions lib/fluent/plugin_helper/compat_parameters.rb
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,13 @@ module CompatParameters
"types" => nil,
"types_delimiter" => nil,
"types_label_delimiter" => nil,
"null_value_pattern" => "null_value_pattern",
"null_empty_string" => "null_empty_string",
"keys" => "keys", # CSVParser, TSVParser (old ValuesParser)
"time_key" => "time_key",
"time_format" => "time_format",
"delimiter" => "delimiter",
"keep_time_key" => "keep_time_key",
"null_empty_string" => "null_empty_string",
"null_value_pattern" => "null_value_pattern",
"json_parser" => "json_parser", # JSONParser
"label_delimiter" => "label_delimiter", # LabeledTSVParser
"format_firstline" => "format_firstline", # MultilineParser
Expand Down
Loading