add a RPC call to flush buffers and stop workers #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,6 +82,16 @@ def run_rpc_server | |||
| end | |||
| nil | |||
| } | |||
| @rpc_server.mount_proc('/api/plugins.flushBuffersAndKillWorkers') { |req, res| | |||
There was a problem hiding this comment.
killWorkers operation is not related with plugins so adding it to plugins prefix seems not good.
processes is better.
tagomoris
force-pushed
the
rpc-call-flush-and-stop
branch
from
9116cdb to
b46e652
Compare
|
@repeatedly could you review once again? |
| @@ -75,6 +75,16 @@ def run_rpc_server | |||
| Process.kill :TERM, $$ | |||
| nil | |||
| } | |||
| @rpc_server.mount_proc('/api/processes.flushBuffersAndKillWorkers') { |req, res| | |||
| $log.debug "fluentd RPC got /api/plugins.flushBuffersAndKillWorkers request" | |||
tagomoris
force-pushed
the
rpc-call-flush-and-stop
branch
from
b46e652 to
8507b3c
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revised version of #1111.