Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not to overwrite something unexpectedly #1119

Merged
merged 3 commits into from
Jul 22, 2016

Conversation

tagomoris
Copy link
Member

Originally, some plugin helpers (e.g., storage, formatter, parser, ...) defines config_section for sets of parameters by included hook. It calls config_section with plugin class as receivers.
But, if plugin class calls config_section to override default value, that overwrites the section definition defined by plugin helpers.
It makes many unexpected behaviors (including breaking instance variables).

This change is to prevent overwriting section definitions by plugins. By inserting a mixin module, config_section definition in plugin classes overrides definitions in plugin helpers, instead of overwriting it.

@tagomoris tagomoris force-pushed the prevent-config-section-overwriting branch from 5f48907 to 9c55c33 Compare July 20, 2016 11:09
@tagomoris
Copy link
Member Author

@repeatedly Could you review this?

@repeatedly
Copy link
Member

okay. I will review it later.

@repeatedly
Copy link
Member

LGTM 👍

@tagomoris tagomoris merged commit 9d0a8dc into master Jul 22, 2016
@ganmacs ganmacs deleted the prevent-config-section-overwriting branch July 11, 2019 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants