Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle ERROR_PATH_NOT_FOUND #1104

Merged
merged 1 commit into from
Jul 13, 2016
Merged

Conversation

ichii386
Copy link
Contributor

On Windows, WindowsFile.new (i.e., in_tail plugin) raises an unhandled error if the path is under non-existent directory.
This has been since FileWrapper.stat() changed not to use FileWrapper.io(), which returns ENOENT unless _open_osfhandle() returns valid fd.

I'm not sure this wouldn't cause any side effect but I report it anyway :)

@repeatedly
Copy link
Member

@nurse Could you check this?

@nurse
Copy link
Contributor

nurse commented Jul 13, 2016

Looks good, thanks!

@nurse nurse merged commit 5030258 into fluent:master Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants