Add parser&filter support for compat_parameters plugin helper #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagomoris
changed the title
tagomoris
force-pushed
the
plugin-helper-compat-parameters-parser-filter
branch
2 times, most recently
from
5622485
to
b50715f
Compare
…y defined in superclass
…written by plugins
…nage it in v0.14)
…arser by using inject plugin helper in filter/output plugin side with conversion of configuration + automated inject_* method invocation for compat plugins
…nique formatter to handle it by itself
…emoved from formatter
…inject plugin helper
tagomoris
force-pushed
the
plugin-helper-compat-parameters-parser-filter
branch
from
b50715f
to
fc380f8
Compare
tagomoris
changed the title
|
@repeatedly Hi, could you please review this? |
|
|
||
| parser_params = {} | ||
| PARSER_PARAMS.each do |older, newer| | ||
| next unless newer |
There was a problem hiding this comment.
PARSER_PARAMS doesn't have false/nil value.
Is this unless for safety?
There was a problem hiding this comment.
Yes. Someone might add another entry which has nil value.
|
Others are LGTM |
|
I added commits for review comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds some methods to convert v0.12 style parser/formatter parameters to v0.14 style. (flat "format" parameter ->
@typein<format>section)With this plugin helper, users can move to v0.14 without any modification on configuration file about formatting/parsing.
This change requires some changes listed below:
default_typekeyword argument in methods of parser/formatter/storage plugin helpers to specify default type of these plugins even without any subsections for these pluginsinjectplugin helper to simulate HandleTagAndTimeMixin in compat filter/output plugins in defaultGenerally speaking, injecting tag/time into records are not of formatter, but filter and output plugins (there are many plugins to do it without formatter plugins). It's best to migrate to use just a code (inject plugin helper) from many similar code in many files.