Fix TestDriver to let plugin instance always to have its class name #1069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed via fluent/fluent-plugin-s3#154
v0.14 TestLogger currently outputs as:
when a TestDriver is created with a block.
v0.14 TestLogger tries to add optional_header like
[#{self.class.name}]
but, TestDriver creates plugin instance with Class.new if block is given, therefore, it does not have class name. In such case we get the extra
[]
.With this fix, we will get
[Fluent::S3Output]
as we expect.