-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split events emitted at once to multi chunks #1062
Merged
tagomoris
merged 16 commits into
master
from
split-events-emitted-at-once-to-multi-chunks
Jul 20, 2016
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a353a36
changing internal API to make it possible to split event streams for …
tagomoris 55eda5f
Add #slice and correct #size method to classes of event stream.
tagomoris 0206472
add for mocking
tagomoris c46b966
use same proc instances for mocking
tagomoris 0012d46
add status "unstaged" for chunks generated but not staged immediately…
tagomoris b5f2e9f
Large event streams from an emit will be split into multi chunks
tagomoris 3fcd1fa
fix with updated status control
tagomoris d7a1128
fix tests with updated buffer internal
tagomoris a1285cf
remove useless statement
tagomoris 94c3f4b
add optional argument to pass size of es (mainly for compat layer)
tagomoris e2bd8aa
fix message to show where the bug is
tagomoris 5ecaca7
Fix bug about stage size calculation
tagomoris ceb4723
rename variable for ease to understand
tagomoris 1fe55f7
delete definition wrongly added when rebased
tagomoris 433b34c
rename to reduce warning
tagomoris fe3a860
add comment about splitting event stream to write into buffer chunks
tagomoris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After unpacked,
@data
should be set tonil
for GC?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...
@data
is used inempty?
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@data
should be kept as is, because#to_msgpack_stream
returns@data
itself.