Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate in syslog to v0.14 API #1061

Merged
merged 5 commits into from
Jul 11, 2016
Merged

Migrate in syslog to v0.14 API #1061

merged 5 commits into from
Jul 11, 2016

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Jun 20, 2016 •
edited
Loading

  • Use v0.14 Input API
  • Use plugin helpers
    • thread
    • parser
    • event_loop
  • Use udp and tcp plugin helpers after available This PR should not contain this change.

cosmo0920 added 2 commits June 24, 2016 22:57
@cosmo0920
Try to use event_loop plugin helper
a1d7bcd
@cosmo0920
Remove thread helper usage
fac84e5 
Because thread helper is used in event_loop plugin helper internally.
@tagomoris
Copy link
Member

LGTM!
I think it's better to merge this change at first, and apply socket(tcp/udp) plugin helper later.

@cosmo0920 cosmo0920 changed the title [WIP] Migrate in syslog to v0.14 API Migrate in syslog to v0.14 API Jul 7, 2016
@cosmo0920
Copy link
Contributor Author

cosmo0920 commented Jul 7, 2016 •
edited
Loading

I've removed [WIP] from PR title.

@tagomoris tagomoris merged commit 4082b65 into fluent:master Jul 11, 2016
@tagomoris
Copy link
Member

Great. Thank you!

@cosmo0920 cosmo0920 deleted the migrate-in_syslog-to-v0.14 branch July 11, 2016 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v0.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cosmo0920 @tagomoris @okkez