Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: "Fiber#storage has borked keys and is being monkey-patched." #4488

Closed
daipom opened this issue May 7, 2024 · 2 comments
Closed

Warning: "Fiber#storage has borked keys and is being monkey-patched." #4488

daipom opened this issue May 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@daipom
Copy link
Contributor

daipom commented May 7, 2024 •
edited
Loading

Describe the bug

This message is shown when executing Fluentd or the tests.

Fiber#storage has borked keys and is being monkey-patched.

fiber-storage gem outputs this message.
It is one of the dependants of console gem.

I don't know when it started to be shown.
I found the cause.
console gem v1.25 specifies the min ver of fiber-local to v1.1.0.
And, fiber-local v1.1.0 somehow causes fiber-storage to output the warning.

I can't find GitHub repository of fiber-storage.
But I can confirm the local gem file, and the message is from fiber-storage.

To Reproduce

$ git clone [email protected]:fluent/fluentd.git
$ cd fluentd
$ bundle
$ bundle exec fluentd --version
Fiber#storage has borked keys and is being monkey-patched.
fluentd 1.17.0

Expected behavior

$ fluentd --version
fluentd 1.17.0

Your Environment

- Fluentd version: 1.17.0
- TD Agent version:
- Operating system: Ubuntu 20.04.6 LTS (Focal Fossa)
- Kernel version: 5.15.0-105-generic

Your Configuration

None

Your Error Log

None

Additional context

No response
@daipom daipom added waiting-for-triage bug Something isn't working and removed waiting-for-triage labels May 7, 2024
This was referenced May 7, 2024
Closed
Closed
daipom added a commit to daipom/fluentd that referenced this issue May 13, 2024
@daipom
log/console_adapter: support console gem v1.25
9e9c5f2 
`Console::Terminal::Logger` class path has changed in `console`
gem v1.25:

socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12

For the v1.25, there is another issue about a warning(fluent#4488):

    Fiber#storage has borked keys and is being monkey-patched.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom mentioned this issue May 13, 2024
Merged
daipom added a commit to daipom/fluentd that referenced this issue May 13, 2024
@daipom
log/console_adapter: support console gem v1.25
daa6c76 
`Console::Terminal::Logger` class path has changed in `console`
gem v1.25:

socketry/console@v1.24.0...v1.25.0#diff-6e7355da8b6a8f794e74e462aebbe4b23f7752dab2a29967d17707eabb71ce12

Note: We can't stop considering the older versions because v1.25
requires Ruby v3.1 or older. 

For the v1.25, there is another issue about a warning(fluent#4488):

    Fiber#storage has borked keys and is being monkey-patched.

Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom
Copy link
Contributor Author

daipom commented May 13, 2024

I have made an issue for fiber-local.

@daipom
Copy link
Contributor Author

daipom commented Jun 17, 2024

I have made an issue for fiber-local.

* ['fiber-storage' outputs warning: Fiber#storage has borked keys and is being monkey-patched. socketry/fiber-local#4](https://github.com/socketry/fiber-local/issues/4)

Fixed.

@daipom daipom closed this as completed Jun 17, 2024
@daipom daipom mentioned this issue Jul 27, 2024
Closed
@daipom daipom mentioned this issue Sep 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daipom