Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose record_accessor internal API #1806

Closed
cosmo0920 opened this issue Dec 28, 2017 · 1 comment
Closed

Expose record_accessor internal API #1806

cosmo0920 opened this issue Dec 28, 2017 · 1 comment

Comments

@cosmo0920
Copy link
Contributor

cosmo0920 commented Dec 28, 2017 •
edited
Loading

Check CONTRIBUTING guideline first and here is the list to help us investigate the problem.

  • fluentd or td-agent version.

Fluentd v1

  • Environment information,

All supported Operating Systems

  • Your configuration

Nope. It is feature request for record_accessor.

  • Your problem explanation. If you have an error logs, write it together.

Currently, record_accessor does not expose internal @keys instance.
We want to use this variable in fluent-plugin-anonymizer like this:

https://github.com/cosmo0920/fluent-plugin-anonymizer/blob/0bb45b93cebc996b6ccb13b5b7a2a71b4682cf14/lib/fluent/plugin/filter_anonymizer.rb#L242-L249

Additional request

Now, @keys does not handle keys correctly when using $['your']['some']['key'] notation.
We also want to use this variable (or API?) above use case.

Already supported above. 🙇‍♂️
@repeatedly
Copy link
Member

repeatedly commented Dec 28, 2017 •
edited
Loading

LGTM > Expose @keys

cosmo0920 added a commit to cosmo0920/fluentd that referenced this issue Dec 29, 2017
@cosmo0920
Expose record_accessor internal instance @keys variable. Fix fluent…
0004370 
…#1806
repeatedly added a commit that referenced this issue Dec 30, 2017
@repeatedly
Merge pull request #1808 from cosmo0920/expose-internal-record_access…
63c61d7 
…or-variable

Expose record_accessor internal instance `@keys` variable. Fix #1806
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@repeatedly @cosmo0920