Skip to content

Commit

Permalink
in_tail: Remove old comments
Browse files Browse the repository at this point in the history
The comments was added in 76f246a.
At that time, closing was done by event-loop.
Now, the situation is completely different.

Currently, there are comments about the `close_io` option in
`shutdown()` and `close()`.
So, it would be enough to remove these comments.

Signed-off-by: Daijiro Fukuda <[email protected]>
  • Loading branch information
daipom committed Jan 31, 2024
1 parent 1529305 commit bbc83bc
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/fluent/plugin/in_tail.rb
Original file line number Diff line number Diff line change
Expand Up @@ -584,10 +584,6 @@ def update_watcher(tail_watcher, pe, new_inode)
detach_watcher_after_rotate_wait(tail_watcher, pe.read_inode)
end

# TailWatcher#close is called by another thread at shutdown phase.
# It causes 'can't modify string; temporarily locked' error in IOHandler
# so adding close_io argument to avoid this problem.
# At shutdown, IOHandler's io will be released automatically after detached the event loop
def detach_watcher(tw, ino, close_io = true)
if @follow_inodes && tw.ino != ino
log.warn("detach_watcher could be detaching an unexpected tail_watcher with a different ino.",
Expand Down

0 comments on commit bbc83bc

Please sign in to comment.