Add a comment which describes why we use String#gsub to replace spaces

fluent · Jan 20, 2020 · bba1a63 · bba1a63
1 parent a5fa046
commit bba1a63
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/fluent/config/v1_parser.rb b/lib/fluent/config/v1_parser.rb
@@ -147,7 +147,9 @@ def parse_include(attrs, elems)
       end
 
       def eval_include(attrs, elems, uri)
-        u = URI.parse(uri.gsub(/ /, '+')) # replace space(s)(' ') with '+' to prevent invalid uri due to space(s).
+        # replace space(s)(' ') with '+' to prevent invalid uri due to space(s).
+        # See: https://github.com/fluent/fluentd/pull/2780#issuecomment-576081212
+        u = URI.parse(uri.gsub(/ /, '+'))
         if u.scheme == 'file' || (!u.scheme.nil? && u.scheme.length == 1) || u.path == uri.gsub(/ /, '+') # file path
           # When the Windows absolute path then u.scheme.length == 1
           # e.g. C: