Merge pull request #3701 from daipom/fix-comments-about-solinger-option

Add comments to `linger_timeout` behavior about Windows
fluent · Apr 4, 2022 · b04e808 · b04e808
2 parents ed9d25e + 52c0ddb
commit b04e808
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/lib/fluent/plugin_helper/server.rb b/lib/fluent/plugin_helper/server.rb
@@ -267,7 +267,9 @@ module ServerTransportParams
           ### Socket Params ###
 
           # SO_LINGER 0 to send RST rather than FIN to avoid lots of connections sitting in TIME_WAIT at src.
-          # Set positive value if needing to send FIN on closing.
+          # Set positive value if needing to send FIN on closing on non-Windows.
+          # (On Windows, Fluentd can send FIN with zero `linger_timeout` since Fluentd doesn't set 0 to SO_LINGER on Windows.
+          # See `socket_option.rb`.)
           # NOTE:
             # Socket-options can be specified from each plugin as needed, so most of them is not defined here for now.
             # This is because there is no positive reason to do so.