command: Remove redundant -cap suffixes from options

Signed-off-by: Hiroshi Hatake <[email protected]>
fluent · Nov 17, 2020 · 787123d · 787123d
1 parent 9a13c58
commit 787123d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/lib/fluent/command/cap_ctl.rb b/lib/fluent/command/cap_ctl.rb
@@ -28,15 +28,15 @@ def prepare_option_parser
         @opts[:clear_capabilities] = true
       }
 
-      @op.on('--add-cap', '--add-capabilities [CAPABILITITY1, CAPABILITY2, ...]', "Add capabilities into Fluentd Ruby") {|s|
+      @op.on('--add [CAPABILITITY1,CAPABILITY2, ...]', "Add capabilities into Fluentd Ruby") {|s|
         @opts[:add_capabilities] = s
       }
 
-      @op.on('--drop-cap', '--drop-capabilities [CAPABILITITY1, CAPABILITY2, ...]', "Drop capabilities into Fluentd Ruby") {|s|
+      @op.on('--drop [CAPABILITITY1,CAPABILITY2, ...]', "Drop capabilities into Fluentd Ruby") {|s|
         @opts[:drop_capabilities] = s
       }
 
-      @op.on('--get-cap', '--get-capabilities', "Get capabilities for Fluentd") {|s|
+      @op.on('--get', "Get capabilities for Fluentd Ruby") {|s|
         @opts[:get_capabilities] = true
       }
 

diff --git a/test/command/test_cap_ctl.rb b/test/command/test_cap_ctl.rb
@@ -19,23 +19,23 @@ class TestFluentCapCtl < Test::Unit::TestCase
 
     test "add capability" do
       logs = capture_stdout do
-        Fluent::CapCtl.new(["--add-cap", "dac_override"]).call
+        Fluent::CapCtl.new(["--add", "dac_override"]).call
       end
       expression = /\AUpdating .* done.\nAdding .*\n/m
       assert_match expression, logs
     end
 
     test "drop capability" do
       logs = capture_stdout do
-        Fluent::CapCtl.new(["--drop-cap", "chown"]).call
+        Fluent::CapCtl.new(["--drop", "chown"]).call
       end
       expression = /\AUpdating .* done.\nDropping .*\n/m
       assert_match expression, logs
     end
 
     test "get capability" do
       logs = capture_stdout do
-        Fluent::CapCtl.new(["--get-cap"]).call
+        Fluent::CapCtl.new(["--get"]).call
       end
       expression = /\ACapabilities in .*,\nEffective:   .*\nInheritable: .*\nPermitted:   .*/m
       assert_match expression, logs
@@ -56,7 +56,7 @@ class TestFluentCapCtl < Test::Unit::TestCase
     test "add capability" do
       logs = capture_stdout do
         Tempfile.create("fluent-cap-") do |tempfile|
-          Fluent::CapCtl.new(["--add-cap", "dac_override", "-f", tempfile.path]).call
+          Fluent::CapCtl.new(["--add", "dac_override", "-f", tempfile.path]).call
         end
       end
       expression = /\AUpdating .* done.\nAdding .*\n/m
@@ -66,7 +66,7 @@ class TestFluentCapCtl < Test::Unit::TestCase
     test "drop capability" do
       logs = capture_stdout do
         Tempfile.create("fluent-cap-") do |tempfile|
-          Fluent::CapCtl.new(["--drop-cap", "chown", "-f", tempfile.path]).call
+          Fluent::CapCtl.new(["--drop", "chown", "-f", tempfile.path]).call
         end
       end
       expression = /\AUpdating .* done.\nDropping .*\n/m
@@ -76,7 +76,7 @@ class TestFluentCapCtl < Test::Unit::TestCase
     test "get capability" do
       logs = capture_stdout do
         Tempfile.create("fluent-cap-") do |tempfile|
-          Fluent::CapCtl.new(["--get-cap", "-f", tempfile.path]).call
+          Fluent::CapCtl.new(["--get", "-f", tempfile.path]).call
         end
       end
       expression = /\ACapabilities in .*,\nEffective:   .*\nInheritable: .*\nPermitted:   .*/m
@@ -87,13 +87,13 @@ class TestFluentCapCtl < Test::Unit::TestCase
   sub_test_case "invalid" do
     test "add capability" do
       assert_raise(ArgumentError) do
-        Fluent::CapCtl.new(["--add-cap", "nonexitent"]).call
+        Fluent::CapCtl.new(["--add", "nonexitent"]).call
       end
     end
 
     test "drop capability" do
       assert_raise(ArgumentError) do
-        Fluent::CapCtl.new(["--drop-cap", "invalid"]).call
+        Fluent::CapCtl.new(["--drop", "invalid"]).call
       end
     end
   end