metrics: Add metrics plugin instance existences checking assertions

Signed-off-by: Hiroshi Hatake <[email protected]>
fluent · Jul 30, 2021 · 123a5f2 · 123a5f2
1 parent 601abda
commit 123a5f2
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 0 deletions.
diff --git a/test/plugin/test_bare_output.rb b/test/plugin/test_bare_output.rb
@@ -98,6 +98,10 @@ class FluentPluginBareOutputTest::DummyPlugin2 < Fluent::Plugin::BareOutput
   test 'can use metrics plugins and fallback methods' do
     @p.configure(config_element('ROOT', '', {'@log_level' => 'debug'}))
 
+    %w[num_errors_metrics emit_count_metrics emit_size_metrics emit_records_metrics].each do |metric_name|
+      assert_true @p.instance_variable_get(:"@#{metric_name}").is_a?(Fluent::Plugin::Metrics)
+    end
+
     assert_equal 0, @p.num_errors
     assert_equal 0, @p.emit_count
     assert_equal 0, @p.emit_size

diff --git a/test/plugin/test_filter.rb b/test/plugin/test_filter.rb
@@ -168,6 +168,10 @@ class FluentPluginFilterTest::DummyPlugin2 < Fluent::Plugin::Filter
     test 'can use metrics plugins and fallback methods' do
       @p.configure(config_element('ROOT', '', {'@log_level' => 'debug'}))
 
+      %w[emit_size_metrics emit_records_metrics].each do |metric_name|
+        assert_true @p.instance_variable_get(:"@#{metric_name}").is_a?(Fluent::Plugin::Metrics)
+      end
+
       assert_equal 0, @p.emit_size
       assert_equal 0, @p.emit_records
     end

diff --git a/test/plugin/test_input.rb b/test/plugin/test_input.rb
@@ -88,6 +88,10 @@ class FluentPluginInputTest::DummyPlugin2 < Fluent::Plugin::Input
   test 'can use metrics plugins and fallback methods' do
     @p.configure(config_element('ROOT', '', {'@log_level' => 'debug'}))
 
+    %w[emit_size_metrics emit_records_metrics].each do |metric_name|
+      assert_true @p.instance_variable_get(:"@#{metric_name}").is_a?(Fluent::Plugin::Metrics)
+    end
+
     assert_equal 0, @p.emit_size
     assert_equal 0, @p.emit_records
   end

diff --git a/test/plugin/test_multi_output.rb b/test/plugin/test_multi_output.rb
@@ -191,6 +191,10 @@ def create_output(type=:multi)
       )
       @i.configure(conf)
 
+      %w[num_errors_metrics emit_count_metrics emit_size_metrics emit_records_metrics].each do |metric_name|
+        assert_true @i.instance_variable_get(:"@#{metric_name}").is_a?(Fluent::Plugin::Metrics)
+      end
+
       assert_equal 0, @i.num_errors
       assert_equal 0, @i.emit_count
       assert_equal 0, @i.emit_size

diff --git a/test/plugin/test_output.rb b/test/plugin/test_output.rb
@@ -226,6 +226,11 @@ def waiting(seconds)
     test 'can use metrics plugins and fallback methods' do
       @i.configure(config_element())
 
+      %w[num_errors_metrics emit_count_metrics emit_size_metrics emit_records_metrics
+         write_count_metrics rollback_count_metrics flush_time_count_metrics slow_flush_count_metrics].each do |metric_name|
+        assert_true @i.instance_variable_get(:"@#{metric_name}").is_a?(Fluent::Plugin::Metrics)
+      end
+
       assert_equal 0, @i.num_errors
       assert_equal 0, @i.emit_count
       assert_equal 0, @i.emit_size