Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: Add Fluentd v1.17.0 release announcement #312

Merged
merged 8 commits into from
Jun 12, 2024
Merged

blog: Add Fluentd v1.17.0 release announcement #312

merged 8 commits into from
Jun 12, 2024

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Apr 30, 2024

cosmo0920
cosmo0920 reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added quite small nitpicks. Could you read carefully and get used to be usage of , (comma) and enumeration of two or more items with and?

content/blog/20240430_fluentd-v1.17.0-has-been-released.md Outdated Show resolved Hide resolved
content/blog/20240430_fluentd-v1.17.0-has-been-released.md Outdated Show resolved Hide resolved
@daipom @cosmo0920
Apply suggestions from code review
60522ff 
Signed-off-by: Daijiro Fukuda <[email protected]>

Co-authored-by: Hiroshi Hatake <[email protected]>
@daipom
Copy link
Contributor Author

daipom commented May 14, 2024

I added quite small nitpicks. Could you read carefully and get used to be usage of , (comma) and enumeration of two or more items with and?

Thanks! I understand! I will take care of that!

@daipom
Add description for enhancements
1834390 
Signed-off-by: Daijiro Fukuda <[email protected]>
cosmo0920
cosmo0920 reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I found errors where are newly added sections.

content/blog/20240430_fluentd-v1.17.0-has-been-released.md Outdated Show resolved Hide resolved
content/blog/20240430_fluentd-v1.17.0-has-been-released.md Outdated Show resolved Hide resolved
daipom and others added 4 commits May 16, 2024 10:05
@daipom @cosmo0920
Improve expression
b2aab89 
Signed-off-by: Daijiro Fukuda <[email protected]>

Co-authored-by: Hiroshi Hatake <[email protected]>
@daipom @cosmo0920
Improve expression
fb90133 
Signed-off-by: Daijiro Fukuda <[email protected]>

Co-authored-by: Hiroshi Hatake <[email protected]>
@daipom
Add description about parser fix
3515e9a 
Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom
Add closing statement
51643f4 
Signed-off-by: Daijiro Fukuda <[email protected]>
@daipom daipom marked this pull request as ready for review June 6, 2024 00:00
@daipom daipom changed the title blog: Add Fluentd v1.17.0 release announcement (WIP) blog: Add Fluentd v1.17.0 release announcement Jun 6, 2024
@daipom
Copy link
Contributor Author

daipom commented Jun 6, 2024

The document fixes related to v1.17:

@daipom daipom requested a review from kenhys June 6, 2024 00:08
@daipom @cosmo0920
Improve expressions
3e5fc8a 
Signed-off-by: Daijiro Fukuda <[email protected]>
Co-authored-by: Hiroshi Hatake <[email protected]>
@daipom
Copy link
Contributor Author

daipom commented Jun 6, 2024

@cosmo0920 Thanks for your review!
I have applied them!

@cosmo0920
Copy link
Contributor

@kenhys Do you have any concerns? If there is no concerns, it's ready to :shipit:!

@daipom
Copy link
Contributor Author

daipom commented Jun 12, 2024

ping @kenhys @ashie
Please take a look when you have time 😃

ashie
ashie approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@ashie ashie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daipom daipom merged commit c08b905 into master Jun 12, 2024
2 checks passed
@daipom daipom deleted the blog-fluentd-v1.17.0 branch June 12, 2024 09:20
@daipom
Copy link
Contributor Author

daipom commented Jun 12, 2024

Thanks!

@daipom
Copy link
Contributor Author

daipom commented Jun 12, 2024

@cosmo0920 @kenhys @ashie Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 left review comments

@ashie ashie ashie approved these changes

@kenhys kenhys Awaiting requested review from kenhys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daipom @cosmo0920 @ashie