This repository has been archived by the owner on May 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
suggested changes
May 7, 2019
docs/v1.0/out_forward.txt
Outdated
|
||
| type | default | version | | ||
|:----:|:-------:|:-------:| | ||
| bool | fales | 0.14.3 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should specify concrete version such as 1.4.3
in version column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your comment. As current fluentd looks v1.4.2(https://github.com/fluent/fluentd/releases/tag/v1.4.2). I changed the version to 1.4.3.
docs/v1.0/out_forward.txt
Outdated
|
||
| type | default | version | | ||
|:----:|:-------:|:-------:| | ||
| time | nil | 0.14.3 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
Signed-off-by: Yuta Iwama <[email protected]>
ganmacs
force-pushed
the
add-keepalive-docs
branch
from
May 8, 2019 07:26
f06ad1e
to
dc93201
Compare
Merged. Thank you. |
fujimotos
pushed a commit
to fujimotos/fluentd-docs-gitbook
that referenced
this pull request
May 17, 2019
This patch contains the changesets made by: * fluent/fluentd-docs#632 * fluent/fluentd-docs#634 * fluent/fluentd-docs#633 Signed-off-by: Fujimoto Seiji <[email protected]>
fujimotos
pushed a commit
to fluent/fluentd-docs-gitbook
that referenced
this pull request
May 17, 2019
This patch contains the changesets made by: * fluent/fluentd-docs#632 * fluent/fluentd-docs#634 * fluent/fluentd-docs#633 Signed-off-by: Fujimoto Seiji <[email protected]>
Side note: I ported this change to the new GitBook site in fluent/fluentd-docs-gitbook/pull/23. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: fluent/fluentd#2393