Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the old value came from
ServerEngine
.However, actually,
ServerEngine
has nothing to do with the rotation, and this value5
is not used at all.Actually,
Logger::LogDevice
manages the rotation, and the default value is7
.In Fluentd code, the parameters of
Fluent::LogDeviceIO
decides the behavior of the rotation.The parameters of
ServerEngine::DaemonLogger
is meaningless.Reproduce
rotate_size
rotate_size 5
rotate_size
: 7 files are createdrotate_size 5
: 5 files are createdThe last index of 7th file is
5
.I think it was hard to notice this mistake because of this.