Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the type of null_value_pattern in configuration/parser-section #393

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

ashie
Copy link
Member

@ashie ashie commented Mar 1, 2022

regexp is appropriate for it.

See also: fluent/fluentd#3650

Signed-off-by: Takuro Ashie [email protected]

`regexp` is appropriate for it.

See also: fluent/fluentd#3650

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie requested a review from kenhys March 1, 2022 09:32
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit 6af8d47 into 1.0 Mar 2, 2022
@ashie ashie deleted the fix-type-of-null_value_pattern branch March 2, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants