Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0: in_tail_with_throttle: Add <group> directive description #376

Merged
merged 3 commits into from
Jun 29, 2022

Conversation

Pranjal-Gupta2
Copy link
Contributor

Documentation for fluent/fluentd#3535

Signed-off-by: Pranjal-Gupta2 [email protected]

@kenhys kenhys added the pending To be done in the future label Oct 21, 2021
@cosmo0920 cosmo0920 added this to the v1.15 milestone Apr 14, 2022
@cosmo0920 cosmo0920 added enhancement New feature or request pending To be done in the future and removed pending To be done in the future enhancement New feature or request labels Apr 14, 2022
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rewrite to be corresponding to fluent/fluentd#3535?
fluent/fluentd#3535 is very reasonable for us but the documentation is also needed to ship into stable release.

@Pranjal-Gupta2 Pranjal-Gupta2 force-pushed the docs/in_tail_with_throttle branch from f3f001c to 3ee0c71 Compare April 25, 2022 20:05
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good for me.

@ashie ashie removed the pending To be done in the future label Jun 29, 2022
input/tail.md Outdated Show resolved Hide resolved
input/tail.md Outdated Show resolved Hide resolved
In addition, remove `higly recommended` label for it.
The priority of this option depends on usage and purpose of users.

Signed-off-by: Takuro Ashie <[email protected]>
@daipom
Copy link
Contributor

daipom commented Jun 29, 2022

Thank you for the fix!

@ashie ashie merged commit 89f39cc into fluent:1.0 Jun 29, 2022
@ashie
Copy link
Member

ashie commented Jun 29, 2022

I merge this since v1.15 has been released.
Thank you for your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants