1.0: Update usage of new service discovery helper API #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashie
requested changes
Jun 1, 2021
Since v1.13.0 new helper API is introduced. It makes supporting service_discovery easy. ref. fluent/fluentd#3299 Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
force-pushed
the
update-service-discovery-plugin-helper
branch
from
d085da3 to
af2b169
Compare
|
Fixed typo. comment from #321 (review) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v1.13.0 new helper API is introduced.
It makes supporting service_discovery easy.
ref. fluent/fluentd#3299