Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https server document #144

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Conversation

ganmacs
Copy link
Member

@ganmacs ganmacs commented Jan 27, 2020

@ganmacs ganmacs requested a review from repeatedly January 27, 2020 08:44
- `proto`: protocol type. `:tcp`, `:tls`. default value is tcp
- `tls_opts`: options for TLS. same as the [Server Helper's server_create_connection tls_options](/developer/api-plugin-helper-server)

### http\_server\_create\_https\_server(title, addr:, port:, logger:, default\_app: nil, &block)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tls_opts is missing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Yuta Iwama <[email protected]>
@ganmacs ganmacs requested a review from repeatedly January 29, 2020 02:38
@ganmacs
Copy link
Member Author

ganmacs commented Jan 31, 2020

May I merge this? @repeatedly

@repeatedly repeatedly merged commit c6068b0 into fluent:1.0 Feb 2, 2020
@repeatedly
Copy link
Member

Released v1.9.1. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants