Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msi: migrate to /opt/fluent #487

Merged
merged 3 commits into from
May 29, 2023
Merged

msi: migrate to /opt/fluent #487

merged 3 commits into from
May 29, 2023

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented May 29, 2023

Before:
c:\opt\td-agent\

After:
c:\opt\fluent\

Note that the following files are not migrated yet:

c:\opt\td-agent\etc\td-agent.conf
c:\opt\td-agent\etc\plugin
c:\opt\td-agent\td-agent.log
c:\opt\td-agent\var\log\td-agent

Thus, most of files are placed under c:\opt\fluent, but these
files are remained for keeping compatibility.

@kenhys
Copy link
Contributor Author

kenhys commented May 29, 2023

Result of changes:

opt-fluent

@daipom
Copy link
Contributor

daipom commented May 29, 2023

Thanks for this fix!

Note that the following files are not migrated yet:

c:\opt\td-agent\etc\td-agent.conf
c:\opt\td-agent\etc\plugin
c:\opt\td-agent\td-agent.log

Thus, most of files are placed under c:\opt\fluent, but these files are remained for keeping compatibility.

I'm concerned about c:\opt\td-agent\var\log\td-agent\ too.
The default config uses this directory for buffer.
We need to figure out how to handle the compatibility of this buffer.

<match td.*.*>
@type tdlog
@id output_td
apikey YOUR_API_KEY
auto_create_table
<buffer>
@type file
<% if windows? %>
path "#{ENV['TD_AGENT_TOPDIR']}/var/log/<%= compat_package_dir %>/buffer/td"
<% else %>
path /var/log/<%= compat_package_dir %>/buffer/td
<% end %>
</buffer>

kenhys added 3 commits May 29, 2023 15:30
Before:
 c:\opt\td-agent\

After:
 c:\opt\fluent\

Note that following files are not migrated yet:

c:\opt\td-agent\etc\td-agent.conf
c:\opt\td-agent\etc\plugin
c:\opt\td-agent\td-agent.log
c:\opt\td-agent\var\log\td-agent\

Thus, most of files are placed under c:\opt\fluent, but these
files are remained for keeping compatibility.

Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys marked this pull request as ready for review May 29, 2023 06:31
@kenhys
Copy link
Contributor Author

kenhys commented May 29, 2023

I'm concerned about c:\opt\td-agent\var\log\td-agent\ too.
The default config uses this directory for buffer.

In this PR, fluentd.bat still point path to c:\opt\td-agent\var\log via TD_AGENT_TOPDIR environment variable.

@daipom
Copy link
Contributor

daipom commented May 29, 2023

I'm concerned about c:\opt\td-agent\var\log\td-agent\ too.
The default config uses this directory for buffer.

In this PR, fluentd.bat still point path to c:\opt\td-agent\var\log via TD_AGENT_TOPDIR environment variable.

Understood! (We will handle the compatibility of these files in future PRs.)

c:\opt\td-agent\etc\td-agent.conf
c:\opt\td-agent\etc\plugin
c:\opt\td-agent\td-agent.log
c:\opt\td-agent\var\log\td-agent

@ashie ashie merged commit 33f482c into fluent:master May 29, 2023
@ashie
Copy link
Member

ashie commented May 29, 2023

Thanks!

@kenhys kenhys deleted the win-opt-fluent branch June 5, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants