Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apt: remove deprecated piuparts stuff #457

Merged
merged 10 commits into from
May 11, 2023
Merged

apt: remove deprecated piuparts stuff #457

merged 10 commits into from
May 11, 2023

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented May 8, 2023

  • xenial (16.04LTS) was already reached EOL.
  • do not skip piuparts for jammy (22.04)
  • use recent gnupg (old version is used for xenial, no
    need to do so)
  • remove unused bionic configuration
  • fix key verification failure of keyring path

@kenhys kenhys force-pushed the tweak-piuparts branch from 247f1d4 to e1676a2 Compare May 8, 2023 06:47
@kenhys
Copy link
Contributor Author

kenhys commented May 8, 2023

checking piuparts failure...

kenhys added 6 commits May 8, 2023 18:17
@kenhys
apt: removed deprecated piuparts stuff
b61d5d4 
* xenial (16.04LTS) was already reached EOL.
* do not skip piuparts for jammy (22.04)
* use recent gnupg (old version is used for xenial, no
 need to do so)
* remove unused bionic configuration
* fix key verification failure of keyring path
* remove unused --keyring option from piuparts

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
apt: remove limitation of jammy
6bdefb0 
There is no need to do so.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
apt: untabify
ef74924 
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
apt: use recent gnupg package
454660c 
No need to use gpg1 (Already dropped Xenial 16.04)

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
apt: fix path of keyrings
be7341f 
path of keyring is passed to piuparts, so use it.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
apt: remove unused bionic verification
488aeac 
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys force-pushed the tweak-piuparts branch from 9e8185f to 3a99013 Compare May 8, 2023 09:18
@kenhys kenhys marked this pull request as ready for review May 8, 2023 09:31
@kenhys
Copy link
Contributor Author

kenhys commented May 9, 2023

rerun failed job.

@kenhys
Copy link
Contributor Author

kenhys commented May 9, 2023

failure seems reproducible, check it...

@kenhys
Copy link
Contributor Author

kenhys commented May 9, 2023

Checking with local bullseye container, piuparts succeeds. 🤔

0m7.2s DEBUG: Removed directory tree at /tmp/tmpbkpkl1yj
0m7.2s INFO: PASS: All tests.
0m7.2s INFO: piuparts run ends.
root@78c2bf2db24b:/# piuparts --distribution=bullseye --existing-chroot=/var/lib/chroot/bullseye-root --mirror="http://packages.treasuredata.com/4/debian/bullseye/ bullseye contrib"  --skip-logrotatefiles-test /tmp/fluent-package_5.0.0-1_amd64.deb

@kenhys
Copy link
Contributor Author

kenhys commented May 9, 2023

It seems that as if no --priviledged is specified, but it is not true for bullseye.

E: Can not write log (Is /dev/pts mounted?) - posix_openpt (19: No such device)

@kenhys
Copy link
Contributor Author

kenhys commented May 9, 2023

E: Can not write log (Is /dev/pts mounted?) - posix_openpt (19: No such device)

It has nothing to do with piuparts error, it is reproducible on local environment.

@kenhys
Copy link
Contributor Author

kenhys commented May 9, 2023

Observed different error with: piuparts --distribution=bullseye --existing-chroot=/var/lib/chroot/bullseye-root --mirror="http://packages.treasuredata.com/4/debian/bullseye/ bullseye contrib" --skip-logrotatefiles-test /tmp/fluent-package_5.0.0-1_amd64.deb on local.

0m9.3s DUMP: 
  diversion of /usr/share/man/man1/sh.1.gz to /usr/share/man/man1/sh.distrib.1.gz by dash
  diversion of /bin/sh to /bin/sh.distrib by dash
0m9.3s DEBUG: Command ok: ['chroot', '/tmp/tmpprjmxwpj', 'dpkg-divert', '--list']
0m9.3s DEBUG: Starting command: ['chroot', '/tmp/tmpprjmxwpj', 'apt-get', 'clean']
0m9.3s DEBUG: Command ok: ['chroot', '/tmp/tmpprjmxwpj', 'apt-get', 'clean']
0m9.3s DEBUG: Recording chroot state
0m9.5s ERROR: FAIL: After purging files have disappeared:
  /opt/	 owned by: fluent-package

0m9.5s ERROR: FAIL: Installation and purging test.

@kenhys
Copy link
Contributor Author

kenhys commented May 9, 2023

The above failure is caused by the fallback of missing access to bullseye/contrib. 🤔

kenhys added 4 commits May 11, 2023 12:22
@kenhys
apt: pre configured apt line
3863dea 
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
apt: remove unused options
4a15689 
--keyring is used to bootstrap chroot image.

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
apt: install missing package
fb74c28 
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
apt: use https://
7435167 
Signed-off-by: Kentaro Hayashi <[email protected]>
@ashie ashie merged commit efca7ea into fluent:master May 11, 2023
@ashie
Copy link
Member

ashie commented May 11, 2023

Thanks!

@kenhys kenhys deleted the tweak-piuparts branch May 16, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashie ashie ashie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenhys @ashie