Update nokogiri to 1.13.6, and install it only on Windows #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fluent-plugin-windows-eventlog and fluent-plugin-parser-winevt_xml are explicitly depdends on nokogiri. Because nokogiri is often reported vulnerabilities, it should be installed and updated by td-agent-gem if users really require it. TODO: Probably we need to install rexml or something other for aws-sdk-core with Ruby 3.x: https://github.com/aws/aws-sdk-ruby/blob/64e9ea97c318cb7a10fdf7c0979307a772f06b51/gems/aws-sdk-core/lib/aws-sdk-core/xml/parser.rb#L70 Signed-off-by: Takuro Ashie <[email protected]>
cosmo0920
approved these changes
May 23, 2022
Probably we don't need to do anything, rexml will be installed automatically. |
|
Noted. Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fluent-plugin-windows-eventlog and fluent-plugin-parser-winevt_xml
are explicitly depdends on nokogiri.
Because nokogiri is often reported vulnerabilities, it should be installed
and updated by td-agent-gem if users really require it.
TODO: Probably we need to install rexml or something other for aws-sdk-core
with Ruby 3.x:
https://github.com/aws/aws-sdk-ruby/blob/64e9ea97c318cb7a10fdf7c0979307a772f06b51/gems/aws-sdk-core/lib/aws-sdk-core/xml/parser.rb#L70
Signed-off-by: Takuro Ashie [email protected]