Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSI: do not remove dll.a for C extensions #130

Merged
merged 1 commit into from
Jul 10, 2020
Merged

MSI: do not remove dll.a for C extensions #130

merged 1 commit into from
Jul 10, 2020

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jul 10, 2020

No description provided.

@kenhys kenhys force-pushed the donot-remove-dll-a branch from 0ca78dc to b6499bf Compare July 10, 2020 00:52
@kenhys
Copy link
Contributor Author

kenhys commented Jul 10, 2020 

$ find . -name '*.dll.a'
./td-agent/lib/libx64-msvcrt-ruby270.dll.a

It keeps dll.a.

@kenhys kenhys marked this pull request as ready for review July 10, 2020 01:00
@kenhys kenhys requested a review from cosmo0920 July 10, 2020 01:00
@ashie ashie merged commit fed6999 into master Jul 10, 2020
@ashie ashie deleted the donot-remove-dll-a branch July 10, 2020 02:49
@ashie ashie mentioned this pull request Jul 10, 2020
Closed
@cosmo0920 cosmo0920 mentioned this pull request Jul 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 Awaiting requested review from cosmo0920

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenhys @ashie