MSI: add log rotation setting

[ashie]

Although the td-agent package for windows automatically set up windows service as of 4.0.0, it doesn't set up log rotation.
We should add default setting for it.

[kenhys]

In the current version, --reg-winsvc-fluentdopt OPTION is the only way to tell option arguments for fluentdwinsvc.
But modifying the specific registry is not appropriate.

https://github.com/fluent/fluentd/blob/master/lib/fluent/command/fluentd.rb#L320
https://github.com/fluent/fluentd/blob/master/lib/fluent/winsvc.rb#L51

It may be better to customize the behavior via environment variables.

[kenhys]

https://github.com/fluent/fluentd/blob/master/lib/fluent/winsvc.rb#L52

Adding options explicitly may be a straightforward way.

[kenhys]

Another idea, it may be useful if <system > section supports it.

<system>
  log_rotate_age 
  log_rotate_size 
</system>

[kenhys]

It may be better to put it under <log>.

[kenhys]

PoC
kenhys/fluentd@349bfb4

[ashie]

Another idea, it may be useful if section supports it.

Sounds good.

[kenhys]

If supporting rotate configuration via fluentd.conf as an option (more general approach, I think)

TODO:

• make configurable via system_config.log.rotate_... in <system><log> ... </log></system> (lib/fluent/system_config.rb)
• fix apply options (lib/fluent/supervisor.rb)
• modify logger to pass these options, maybe need to take care of DeamonLogger (lib/fluent/log.rb)

[kenhys]

In supervisor, it may be better to parse 2-pass with/without additional_config.

[kenhys]

I'm working on fluent/fluentd#3352 It is under development.

[kenhys]

It is not MSI specific feature #284 (comment) , so I'll close this.