tls: macos load system certificates using security framework. #9539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niedbalski
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
4 tasks
cosmo0920
reviewed
Oct 30, 2024
Contributor
cosmo0920
left a comment
cosmo0920
left a comment
There was a problem hiding this comment.
Basically, the implementation should be good. I added a small concerns for coding style, message style, and the counter to count already loaded certificates.
Load the system certicates using the security framework instead of a depending on a local pem file. Signed-off-by: Jorge Niedbalski <jorge.niedbalski@chronosphere.io>
niedbalski
force-pushed
the
niedbalski-tls-macos
branch
from
d82ebfd to
3a5f3de
Compare
scne59
pushed a commit
to scne59/fluent-bit
that referenced
this pull request
Apr 9, 2025
…#9539) Load the system certificates using the security framework instead of depending on a local bundled pem file. Signed-off-by: Jorge Niedbalski <jorge.niedbalski@chronosphere.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch should be stacked after
I realised that none of the expected locations for the PEM files was available on my machine. I had some PEM files created by the brew installer but none of them were being detected by fluent-bit.
If the plugin didn't have explicilty set to tls.verify off, I would get a certify verify failed, no matter on which
location I place my CA ring or my pem files.
Configuration used before
[CUSTOM] name calyptia api_key xxxx fleet_name test-jorge calyptia_tls.verify on calyptia_host cloud-api.calyptia.comTherefore, I decided to check if the security framework had the certificates I needed for Letsencrypt, and to my surprise all of those certs were available on the machine
security find-certificate -a /System/Library/Keychains/SystemRootCertificates.keychainTherefore I decided to load certificates from SecTrustSettingsCopyCertificates using the security framework to avoid relying on local certificate paths.
This patch is an implementation of that approach. With this patch applied I get the following output:
Testing
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.