Skip to content

Conversation

@github-actions
Copy link
Contributor

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@edsiper edsiper changed the base branch from master to 3.1 September 28, 2024 00:39
@edsiper edsiper requested a review from pwhelan as a code owner September 28, 2024 00:39
@edsiper edsiper changed the base branch from 3.1 to master September 28, 2024 00:40
@edsiper
Copy link
Member

edsiper commented Sep 28, 2024

@patrick-stephens when changing the base branch of this PR to 3.1 the list of commits is huge (it seems it does a rebase of master), what would be the proper way to fix it ?

@patrick-stephens
Copy link
Collaborator

patrick-stephens commented Sep 30, 2024

@patrick-stephens when changing the base branch of this PR to 3.1 the list of commits is huge (it seems it does a rebase of master), what would be the proper way to fix it ?

I think we need to update the CI to start from the base branch, it's checking out master so needed to be updated when we created the 3.1 branch. We should have a runbook for what to do when you create those branches (e.g. set branch protections, update CI, etc.)

@patrick-stephens
Copy link
Collaborator

@edsiper see #9444

@patrick-stephens patrick-stephens deleted the create-pull-request/patch branch September 30, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants