cmake: Correctly fetch FLB_GIT_HASH from signed commit#9070
Merged
edsiper merged 1 commit intofluent:masterfrom Jul 11, 2024
Merged
cmake: Correctly fetch FLB_GIT_HASH from signed commit#9070edsiper merged 1 commit intofluent:masterfrom
edsiper merged 1 commit intofluent:masterfrom
Conversation
If git is configured to show the signature in `git log` then the extraction of the commit hash breaks. So instead call `git log` with the `-c log.showSignature=false` config options. Signed-off-by: xl-sec <31486311+xl-sec@users.noreply.github.com>
xl-sec
requested review from
celalettin1286,
fujimotos,
niedbalski and
patrick-stephens
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If git is configured to show the signature in
git logthen the extraction of the commit hash breaks. So instead callgit logwith the-c log.showSignature=falseconfig options.Fixes #9064
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.