http_server and downstream: fix keepalive issues#9038
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@calyptia.com>
This patch, add extra checks per protocol version and user configuration based on the net_setup flag passed so it can honor when to keep the connection persistent and when it must be closed, this fixes the issues associated with different setups for: - http2: off - http2: on - net.keepalive: on - net.keepalive: off This PR is a continuation of work that started on troubleshooting #9010. Signed-off-by: Eduardo Silva <eduardo@calyptia.com>
edsiper
requested review from
fujimotos,
koleini and
leonardo-albertovich
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is still work in progress. As of now keepalive issues are fixed, however we are waiting for some unit tests to validate proper behaviors on:
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.