Skip to content

http_server: Disable keepalive automatically when HTTP/1.1 and keepalive is enabled for curl requests #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cosmo0920 wants to merge 2 commits into from
Closed

http_server: Disable keepalive automatically when HTTP/1.1 and keepalive is enabled for curl requests #9019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87ee0f5
http_server: Add hotfix for disabling keepalive when HTTP2 upgrade is…
cosmo0920 Jul 2, 2024
b27bff1
http_server: Disable keepalive when curl requests are ingested.
cosmo0920 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/http_server/flb_http_server.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,21 @@ int flb_http_server_session_ingest(struct flb_http_server_session *session,
if (result != 0) {
return -1;
}

if (strstr(session->incoming_data,
"User-Agent: curl") != NULL) {
/* FIXME: Auto disabling keepalive for curl requests due to not return responses
* when enabled to HTTP/1.1 with keepalive. This should be harmful
* for splunk input case. This is because Splunk HEC
* requests are expected to return response code response
* with JSON representation. Meanwhile, we need to
* disable keepalive automatically in this code path. */
if (session->version == HTTP_PROTOCOL_HTTP1) {
if (session->parent->flags & FLB_HTTP_SERVER_FLAG_KEEPALIVE) {
session->parent->flags &= ~FLB_HTTP_SERVER_FLAG_KEEPALIVE;
}
}
}
}
else if (session->version == HTTP_PROTOCOL_HTTP2) {
result = flb_http2_server_session_init(&session->http2, session);
Expand Down