Skip to content

processor_content_modifier: logs: do not fail if keys are not found #9005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edsiper merged 1 commit into from
Jun 25, 2024
Merged

processor_content_modifier: logs: do not fail if keys are not found #9005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions plugins/processor_content_modifier/cm_logs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ static int run_action_insert(struct content_modifier_ctx *ctx,
ret = cfl_kvlist_insert_string_s(kvlist, key, cfl_sds_len(key), value, cfl_sds_len(value),
CFL_FALSE);
if (ret != 0) {
printf("Failed to insert key: %s\n", key);
flb_plg_debug(ctx->ins, "[action: insert] failed to insert key: %s", key);
return -1;
}
return 0;
Expand Down Expand Up @@ -451,7 +451,10 @@ static int run_action_delete(struct content_modifier_ctx *ctx,
return 0;
}

return -1;
flb_plg_debug(ctx->ins, "[action: delete] key '%s' not found", key);

/* if the kvpair was not found, it's ok, we return zero */
return 0;
}

static int run_action_rename(struct content_modifier_ctx *ctx,
Expand All @@ -465,7 +468,8 @@ static int run_action_rename(struct content_modifier_ctx *ctx,
/* if the kv pair already exists, remove it from the list */
kvpair = cfl_object_kvpair_get(obj, key);
if (!kvpair) {
return -1;
flb_plg_debug(ctx->ins, "[action: rename] key '%s' not found", key);
return 0;
}

tmp = kvpair->key;
Expand Down