Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
7 tasks
There was a problem hiding this comment.
While at it maybe you also want to fix the typo on line 653 ?
Member
|
@cosmo0920 thanks, pls submit a backport for 3.0 branch too. |
Contributor
Author
Hi, #8967 is a backport PR to be corresponding to this. :) |
edsiper
deleted the
cosmo0920-provide-restoring-way-for-tls.verify-hebavior
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8959.
The previous enforced hostname verification with tls.verify breaks some of the certificates
for kubelet. We should restore functionality and make opt-in feature for hostname verification in TLS.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Example configuration file for the change
Same as in TLS security issue: tls.verify is not validating host subject alternative name #8072. But it needs to add
tls.verify_hostname onfor hostname verification.Debug log output from testing the change
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
fluent/fluent-bit-docs#1393
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.