Improved OpenTelemetry OTLP error handling#8962
Merged
edsiper merged 3 commits intofluent:masterfrom Jun 25, 2024
Merged
Conversation
Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
…age in non-ok handling cases Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
3a57581 to
dbd4997
Compare
cosmo0920
requested changes
Jun 21, 2024
Member
|
commits were squashed and commit fixed. |
Contributor
Author
|
Somehow missed emails about this the other week. Thanks for cleaning up the commits. Will use the right prefix moving forwards :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to the OpenTelemetry input plugin's HTTP/2 server code to handle/report error cases better.
These were changes I made as part of other work trying to fix #8734 - but I have split them out into a separate PR as I can imagine they may need to be reviewed separately.
Testing requirements
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.