Conversation
…en address
Before this commit, fluent-bit -J produces the incorrect schema for
listen address for ip.
host should be used for specifing to hostname.
And, listen parameter should be used for setting up for listen address.
This is because the following lines in flb_input.c:
```c
else if (prop_key_check("listen", k, len) == 0) {
flb_utils_set_plugin_string_property("listen", &ins->host.listen, tmp);
}
else if (prop_key_check("host", k, len) == 0) {
flb_utils_set_plugin_string_property("host", &ins->host.name, tmp);
}
```
Set up for listen address and hostname respectively.
And the host member is typed as struct flb_net_host whose definition is:
```c
struct flb_input_instance {
/* snip */
/*
* Input network info:
*
* An input plugin can be specified just using it shortname or using the
* complete network address format, e.g:
*
* $ fluent-bit -i cpu -o plugin://hostname:port/uri
*
* where:
*
* plugin = the output plugin shortname
* name = IP address or hostname of the target
* port = target TCP port
* uri = extra information that may be used by the plugin
*/
struct flb_net_host host;
/* snip */
};
```
Then, the type of struct flb_net_host should be:
```c
/* Defines a host service and it properties */
struct flb_net_host {
int ipv6; /* IPv6 required ? */
flb_sds_t address; /* Original address */
int port; /* TCP port */
flb_sds_t name; /* Hostname */
flb_sds_t listen; /* Listen interface */
struct flb_uri *uri; /* Extra URI parameters */
};
```
So, the usage and generating for host and listen parameters are inverted
and I have to add a host config_map for DNS resolutions.
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Member
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, fluent-bit -J produces the incorrect schema for listen address for ip.
host should be used for specifing to hostname.
And, listen parameter should be used for setting up for listen address.
This is because the following lines in flb_input.c:
Set up for listen address and hostname respectively. And the host member is typed as struct flb_net_host whose definition is:
Then, the type of struct flb_net_host should be:
So, the usage and generating for host and listen parameters are inverted
and I have to add a host config_map for DNS resolutions.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.