Skip to content

in_kubernetes_events: refactor time check to use struct flb_time.#8887

Merged
edsiper merged 1 commit intomasterfrom
pwhelan-fix-kubernetes-events-event_is_filtered
Jun 5, 2024
Merged

in_kubernetes_events: refactor time check to use struct flb_time.#8887
edsiper merged 1 commit intomasterfrom
pwhelan-fix-kubernetes-events-event_is_filtered

Conversation

@pwhelan
Copy link
Contributor

@pwhelan pwhelan commented May 28, 2024

Summary

Fixes a build error when building in_kubernetes_events caused by code that was not properly refactored. This is basically a reaplication of #8845 to master.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Phillip Whelan <phil@calyptia.com>
@ryanohnemus
Copy link
Contributor

FYI this is also updated in https://github.com/fluent/fluent-bit/pull/8351/files#diff-1a15ea37009c42dc8379f6cb3b917480c16dca48c111b7bbbca3af0ee016ebeaR297, if we can bring that change up to this same milestone, i don't think we'd need to merge this change.

@edsiper
Copy link
Member

edsiper commented Jun 5, 2024

@ryanohnemus FYI: we are going to merge #8351 for 3.1

@edsiper edsiper merged commit 0b75c90 into master Jun 5, 2024
@edsiper edsiper deleted the pwhelan-fix-kubernetes-events-event_is_filtered branch June 5, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants