in_http: respond accordingly to requests that produce errors.#8794
Merged
in_http: respond accordingly to requests that produce errors.#8794
Conversation
return a 400 error when the incoming message is invalid, unable to be processed or cannot be appended as a log entry. at the moment only the logs themselves can distinguish these different error cases but at least clients will be alerted to problems. Signed-off-by: Phillip Whelan <phil@calyptia.com>
… errors. Signed-off-by: Phillip Whelan <phil@calyptia.com>
pwhelan
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Member
|
for the commits that targets the tests interface, the prefix commit should be:
ref:
|
edsiper
requested changes
May 15, 2024
Member
edsiper
left a comment
edsiper
left a comment
There was a problem hiding this comment.
changes requested in the commit prefix for the tests
This was referenced Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This request attempts to respond with error codes to requests that run into them for whatever reason, this includes:
Any other error scenarios should also have tests added for them as both of the first ones have them.
Description
Currently the
in_httpplugin makes no attempt to signal to the client if an error occurs while trying to ingest their records. This PR attempts to address that.At the moment there is no attempt to actually report the error back to the client, or even to hint at its nature. A 400 error response is sent under any and all circumstances. This is in part to avoid leaking information the client as much as it is the lack of faculties to do so in fluent-bit.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.