utils: floating-point number support in size-to-bytes conversion#8767
Merged
edsiper merged 3 commits intofluent:masterfrom Jun 25, 2024
Merged
Conversation
Signed-off-by: Meet <meetp0878@gmail.com>
Signed-off-by: Meet <meetp0878@gmail.com>
cosmo0920
requested changes
May 13, 2024
Contributor
There was a problem hiding this comment.
Basically, the change looks attractive. But, is there any chance to add unit tests to verify whether this change is effective or not?
You can add your adding test(s) in https://github.com/fluent/fluent-bit/blob/master/tests/internal/utils.c.
Signed-off-by: Meet <meetp0878@gmail.com>
Contributor
Author
Okay, I've added a unit test for the change!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue, which is that the flb_utils_size_to_bytes function is only processing non-floating numbers even after providing a floating-number in configuration.
It would address one aspect of the performance issues (Ref: #8673)
[2024/04/23 18:34:22] [debug] [input:winevtlog:winevtlog.0] read limit per cycle is set up as 976.6K[2024/04/23 18:42:00] [debug] [input:winevtlog:winevtlog.0] read limit per cycle is set up as 976.6KEnter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.