Skip to content

out_datadog: Update the descriptions of special field options#8751

Merged
edsiper merged 1 commit intofluent:masterfrom
jszwedko:jszwedko/update-datadog-output-field-docs
May 15, 2024
Merged

out_datadog: Update the descriptions of special field options#8751
edsiper merged 1 commit intofluent:masterfrom
jszwedko:jszwedko/update-datadog-output-field-docs

Conversation

@jszwedko
Copy link
Contributor

These options are useful when there is no attribute in the incoming log that indicates the field to use for the source or service attributes, but otherwise the backend will automatically look for both in the incoming log attributes.

Ref: #8687

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

These options are useful when there is no attribute in the incoming log
that indicates the field to use for the `source` or `service`
attributes, but otherwise the backend will automatically look for both
in the incoming log attributes.

Ref: fluent#8687

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko
Copy link
Contributor Author

This is a docs only update so I don't think most of the normal PR checklist is relevant, but let me know if you want me to run any of it.

I'll open a separate PR to update the website docs.

@jszwedko jszwedko changed the title Update the descriptions of datadog output field options out_datadog: Update the descriptions of special field options Apr 23, 2024
jszwedko added a commit to jszwedko/fluent-bit-docs that referenced this pull request Apr 23, 2024
Follow-up on the similar changes to the help docs in fluent-bit: fluent/fluent-bit#8751

Ref: fluent/fluent-bit#8751
Ref: fluent/fluent-bit#8687

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@lecaros
Copy link
Contributor

lecaros commented Apr 25, 2024

lecaros pushed a commit to fluent/fluent-bit-docs that referenced this pull request Apr 25, 2024
Follow-up on the similar changes to the help docs in fluent-bit: fluent/fluent-bit#8751

Ref: fluent/fluent-bit#8751
Ref: fluent/fluent-bit#8687

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@jszwedko jszwedko changed the title out_datadog: Update the descriptions of special field options out_datadog: Update the descriptions of special field options Apr 29, 2024
@jszwedko
Copy link
Contributor Author

Hi @jszwedko, thanks for the PR. Please review https://github.com/fluent/fluent-bit/actions/runs/8808240473/job/24176934107?pr=8751

Thanks for the pointer! I think the PR title should be ok now.

@lecaros lecaros added this to the Fluent Bit v3.0.4 milestone Apr 29, 2024
@edsiper edsiper merged commit 1252ffa into fluent:master May 15, 2024
@edsiper
Copy link
Member

edsiper commented May 15, 2024

thanks for the contribution. Note that the requested change by @lecaros was about the commit subject (since this is a minor change I just change it in the squash process, all good)

markuman pushed a commit to markuman/fluent-bit that referenced this pull request May 29, 2024
…8751

These options are useful when there is no attribute in the incoming log
that indicates the field to use for the `source` or `service`
attributes, but otherwise the backend will automatically look for both
in the incoming log attributes.

Ref: fluent#8687

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Markus Bergholz <git@osuv.de>
TomlinfreeGit pushed a commit to TomlinfreeGit/fluent-bit-docs that referenced this pull request Oct 28, 2025
…ent#1360)

Follow-up on the similar changes to the help docs in fluent-bit: fluent/fluent-bit#8751

Ref: fluent/fluent-bit#8751
Ref: fluent/fluent-bit#8687

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
Signed-off-by: Tom <yao.lin@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants