flb_input: Config parsing order fixed for storage.pause_on_chunks_overlimit#8720
Merged
edsiper merged 1 commit intofluent:masterfrom Jul 12, 2024
Merged
Conversation
This commit fixes a dependency issue for the storage.pause_on_chunks_overlimit parameter. In case the order in the config file was storage.pause_on_chunks_overlimit On storage.type Filesystem then the storage.pause_on_chunks_overlimit was ignored. This commit changes this behavior, so that the storage.pause_on_chunks_overlimit parameter will be parsed and set. It will be reset in case the storage.type is set to a different type than FS later. Signed-off-by: Richard Treu <richard.treu@sap.com>
drbugfinder-work
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Contributor
Author
|
Ping @pwhelan Can you please have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a dependency issue for the
storage.pause_on_chunks_overlimitparameter.In case the order in the config file was
then the
storage.pause_on_chunks_overlimitwas ignored.This PR changes this behavior, so that the
storage.pause_on_chunks_overlimitparameter will be parsed and set. It will be reset in case thestorage.typeis set to a different type than FS later.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.