packaging: build: Make to be able to replace docker cli via environment variable#8612
Merged
patrick-stephens merged 2 commits intomasterfrom Mar 21, 2024
Merged
Conversation
…nt variable Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
celalettin1286
previously approved these changes
Mar 21, 2024
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Contributor
Author
|
Sorry, I'd overlooked for shellcheck failure. I re-requested for reviewing. |
patrick-stephens
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theoretically, podman cli could be used for creating packages. The default command for container cli should be docker.
To use podman instead of docker, define
FLB_DOCKER_CLI=podman. Then podman is working with build and run commands.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.