engine_dispatch: remove chunks from memory if the task fails to be created #8601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seblaz
requested review from
edsiper,
fujimotos,
koleini and
leonardo-albertovich
as code owners
Contributor
|
Looks like this is based off a broken commit on master, can you rebase? |
Signed-off-by: seblaz <[email protected]>
seblaz
changed the title
|
hi @seblaz @patrick-stephens will this fix be backported to older versions of fluentbit. |
…eated When the tasks_map is filled and the new arriving chunks try to create a new task, then an error is returned. Additionally, under that condition the new chunks don't get deleted from memory, and they occupy a space of the storage.max_chunks_up. Eventually, the new chunks end up using the entire space of the storage.max_chunks_up. This causes the old chunks that have a task assigned to be unable to be brought up into memory, and therefore they never get flushed. This pr fixes the problem by deleting the new chunks from memory in case they failed to create a task and the filesystem storage is in use. Additionally, it runs a check to not bring it up to memory in the first place if possible. Signed-off-by: seblaz <[email protected]>
leonardo-albertovich
approved these changes
Apr 5, 2024
Contributor
leonardo-albertovich
left a comment
leonardo-albertovich
left a comment
There was a problem hiding this comment.
This PR should be merged ASAP.
Thanks a lot for taking the time to fix this issue Sebastian!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task is not created and the filesystem storage is used, then set the chunk down
Fixes #8395 #7329 #5485 #5217
Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.