workflows: windows: Add chain workflow for windows unit testing#8582
Merged
patrick-stephens merged 8 commits intomasterfrom Mar 27, 2024
Merged
Conversation
cosmo0920
requested review from
celalettin1286,
edsiper,
fujimotos,
koleini,
leonardo-albertovich,
niedbalski and
patrick-stephens
as code owners
cosmo0920
changed the title
cosmo0920
force-pushed
the
cosmo0920-add-chain-workflow-for-windows-unit-testing
branch
from
b077178 to
2fd5384
Compare
patrick-stephens
requested changes
Mar 15, 2024
Contributor
patrick-stephens
left a comment
patrick-stephens
left a comment
There was a problem hiding this comment.
I think we should split the build and test into at least separate steps with an upload in between, ideally though into a separate job for downloading and running the binaries on a clean runner.
patrick-stephens
approved these changes
Mar 18, 2024
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
In Windows, the newline(\n) characters in internal test data are replaced with \r\n by git settings: core.autocrlf true. This settings accicdentally converting the newlines. This commit handles the converted characters. Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Patrick Stephens <pat@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-add-chain-workflow-for-windows-unit-testing
branch
from
0de2602 to
ee89020
Compare
Signed-off-by: Pat <patrick.j.k.stephens@gmail.com> Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
cosmo0920
force-pushed
the
cosmo0920-add-chain-workflow-for-windows-unit-testing
branch
from
ee89020 to
79a1793
Compare
patrick-stephens
approved these changes
Mar 27, 2024
Contributor
|
Once green I'll merge |
patrick-stephens
deleted the
cosmo0920-add-chain-workflow-for-windows-unit-testing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we're using GitHub Actions just for building confirmation on Windows.
This shouldn't sufficient to testing the internal tests.
Because AppVeyor CI tasks are not actively maintained. So, we have motivations to migrate unit test for Windows from AppVeyor to GitHub Actions.
This PR aims to translate and migrate the unit tests from AppVeyor style to GitHub Actions and just add chain workflows after the Windows compilation and uploading artefacts into S3.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.